TULIP issueshttps://git.list.lu/nui/tulip/-/issues2017-06-08T21:33:59Zhttps://git.list.lu/nui/tulip/-/issues/20Inconsistent version numbering2017-06-08T21:33:59ZEric Tobiaseric.tobias@list.luInconsistent version numberingAs an example, take the BluetoothAdapter. It shows has having been added as of version 1.0. This is not the case. the current version stamp is 2.0.41. You probably started working on it as soon as 2.0.1 though. Please correct the version...As an example, take the BluetoothAdapter. It shows has having been added as of version 1.0. This is not the case. the current version stamp is 2.0.41. You probably started working on it as soon as 2.0.1 though. Please correct the version numbering.Integrate Nicola's workNicolas GilmardNicolas Gilmardhttps://git.list.lu/nui/tulip/-/issues/19Complete documentation on EventLogger2017-08-02T19:22:59ZEric Tobiaseric.tobias@list.luComplete documentation on EventLoggerThe documentation is lacking and the naming conventions have been severely maimed. The class needs to be reworked.The documentation is lacking and the naming conventions have been severely maimed. The class needs to be reworked.Initial stable releasehttps://git.list.lu/nui/tulip/-/issues/17Inconsistent contract management2017-06-08T21:33:59ZEric Tobiaseric.tobias@list.luInconsistent contract managementUsing Design by Contract and the proper annotations should be encouraged. Adding @NonNullByDefault on class level makes all methods, parameters, fields, etc to be non-null by default. Hence, the @pre annotation mentioning that some param...Using Design by Contract and the proper annotations should be encouraged. Adding @NonNullByDefault on class level makes all methods, parameters, fields, etc to be non-null by default. Hence, the @pre annotation mentioning that some parameter cannot be null is redundant.
With the correct IDE setup possible null values are shown as errors/warnings. If a contract is documented, you have to assume it is fulfilled.Integrate Nicola's workNicolas GilmardNicolas Gilmardhttps://git.list.lu/nui/tulip/-/issues/15Inconsistent precondition2017-06-08T21:33:59ZEric Tobiaseric.tobias@list.luInconsistent preconditionTuioAdapter Line 98
The precondition mentions all interface managers needing to be instantiated but it only checks one.TuioAdapter Line 98
The precondition mentions all interface managers needing to be instantiated but it only checks one.Integrate Nicola's workNicolas GilmardNicolas Gilmardhttps://git.list.lu/nui/tulip/-/issues/13Clean properties file2017-06-08T21:33:59ZEric Tobiaseric.tobias@list.luClean properties fileClean the properties file of all unnecessary additions. However, leave some clear documentation in the file for properties that need to be added by any client application (including the expected syntax).Clean the properties file of all unnecessary additions. However, leave some clear documentation in the file for properties that need to be added by any client application (including the expected syntax).Integrate Nicola's workNicolas GilmardNicolas Gilmardhttps://git.list.lu/nui/tulip/-/issues/10Complete documentation2017-06-08T21:33:59ZEric Tobiaseric.tobias@list.luComplete documentationDocumentation should be completed with meaningful and stringent comments and Javadoc. This includes well chosen method and field names as well as parameters. Don't abbreviate where not necessary. Class names should not be redundant. "Tui...Documentation should be completed with meaningful and stringent comments and Javadoc. This includes well chosen method and field names as well as parameters. Don't abbreviate where not necessary. Class names should not be redundant. "TuioConcreteAdapter" has both "Tuio" and "Concrete" in its name. One suffices.
Examples: Why call getObjectId() on TangibleObject? Is there another identifier than that of the object? Don't abbreviate object to obj in some cases.
* [ ] TangibleObject
* [ ] TangibleObjectBuilder
* [ ] TuiAdapter
* [ ] TuioConcreteAdapter
* [ ] BluetoothClient
* [ ] BluetoothServer
* [ ] ClientAdapter
* [ ] NetworkAdapter
* [ ] ServerAdapter
* [ ] TcpClient
* [ ] TcpServer
* [ ] XbeeAdapter
Same holds true for tests.Integrate Nicola's workNicolas GilmardNicolas Gilmard